Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix rest unit test #1074

Merged
merged 2 commits into from
Nov 5, 2021
+1 −1
Merged

fix: fix rest unit test #1074

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb83fb
fix: fix rest unit test
vam-google Nov 5, 2021
8eaa38b
:Merge remote-tracking branch 'upstream/master'
vam-google Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gapic/templates/tests/unit/gapic/%name_%version/%sub/test_%service.py.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,7 @@ def test_{{ method.name|snake_case }}_rest_flattened(transport: str = 'rest'):
assert len(req.mock_calls) == 1
_, args, _ = req.mock_calls[0]
{% with uri = method.http_options[0].uri %}
assert path_template.validate("https://{{ service.host }}{{ uri }}", args[1])
assert path_template.validate("https://%s{{ uri }}" % client.transport._host, args[1])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have a "golden" example for a REST API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we do not, but I think we should.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we do not, but I think it is a good idea to have one.

{% endwith %}
{# TODO(kbandes) - reverse-transcode request args to check all request fields #}

Expand Down