Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Remove monolith imports from Python µgen Bazel rules #923

Merged
merged 6 commits into from
Jun 21, 2021

Conversation

miraleung
Copy link
Contributor

@miraleung miraleung commented Jun 18, 2021

This is needed so that we can remove the monolith from googleapis's switched_rules_by_language. Without this change, py_gapic targets that depend on a proto_library_with_info target will fail to build, because the monolith import clobbers the @rules_gapic//:proto_library_with_info import in googleapis.

We need to temporarily disable the integration tests because the googleapis depndencies (e.g. asset_proto) were themselves dependent on the monolith's rules... but that import must be removed here in order to facilitate removing the monolith from googleapis. These tests will be re-enabled once the googleapis change is done.

@miraleung miraleung requested a review from a team as a code owner June 18, 2021 02:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@0dfac03). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 8feb9c4 differs from pull request most recent head e4f8b81. Consider uploading reports for the commit e4f8b81 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             master      #923   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        27           
  Lines             ?      1703           
  Branches          ?       347           
==========================================
  Hits              ?      1703           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
gapic/schema/__init__.py 100.00% <ø> (ø)
gapic/generator/generator.py 100.00% <100.00%> (ø)
gapic/samplegen/__init__.py 100.00% <100.00%> (ø)
gapic/samplegen/manifest.py 100.00% <100.00%> (ø)
gapic/samplegen/samplegen.py 100.00% <100.00%> (ø)
gapic/samplegen_utils/__init__.py 100.00% <100.00%> (ø)
gapic/samplegen_utils/types.py 100.00% <100.00%> (ø)
gapic/samplegen_utils/utils.py 100.00% <100.00%> (ø)
gapic/samplegen_utils/yaml.py 100.00% <100.00%> (ø)
gapic/schema/api.py 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dfac03...e4f8b81. Read the comment docs.

@miraleung miraleung requested a review from a team as a code owner June 18, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants