test: test hapi tails #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Does this still fix #382 ? |
|
@ofrobots The Hapi API for request tails doesn't give us enough control to define a new root span under which tail work will be associated. It's also a removed API in v17+ so I would consider it not high priority to support additional instrumentation specific to Hapi tails beyond just this test. |
ofrobots
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #382
Since child spans are now allowed to track tail latencies, this PR adds a test to ensure that users of the Hapi tails API (up to v16, but also including the more general recommended mechanism in the v17 release notes under "Misc") can observe these child spans.
Note that child spans still cannot begin after a root span has ended.