Use GCLOUD_PROJECT instead of GCLOUD_PROJECT_NUM #237
Conversation
googlebot
added
the
cla: yes
|
@ofrobots PTAL. |
|
Looking at https://www.npmjs.com/package/gcloud, they are using |
matthewloring
changed the title
|
Fixed. |
matthewloring
changed the title
|
For posterity, that was a bug in |
| @@ -24,17 +24,17 @@ This module provides Cloud Trace support for Node.js applications. [Google Cloud | |||
|
|
|||
| npm install --save @google/cloud-trace | |||
|
|
|||
| 2. Include and start the library at the *top of the main script of your application*. It's important that Cloud Trace is the first thing executed so that it can accurately gather data: | |||
| 2. If you are running locally, or not on the Google Cloud Platform, set the GCLOUD_PROJECT environment variable. Your project ID is visible in the [Google Cloud Console Console](https://console.cloud.google.com/project?_ga=1.258049870.576536942.1443543237), it may be something like `particular-future-12345`. If your application is [running on Google Cloud Platform](running-on-google-cloud-platform), you don't need to specify the project ID. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
This is looking a lot better folks. LGTM. Lets get the GCLOUD_PROJECT change in, and then if needed we can bikeshed the readme prose. |
|
@ofrobots @JustinBeckwith I've taken another editing pass at this. |
| @@ -24,17 +24,24 @@ This module provides StackDriver Trace support for Node.js applications. [StackD | |||
|
|
|||
| npm install --save @google/cloud-trace | |||
|
|
|||
| 2. Include and start the library at the *top of the main script of your application*. It's important that the trace agent is the first thing executed so that it can accurately gather data: | |||
| 2. Set the GCLOUD_PROJECT environment variable. You can find your Project ID in the [Google Cloud Developers Console](https://console.cloud.google.com/project?_ga=1.258049870.576536942.1443543237), or by running the command `gcloud projects list`. You can ensure this environment variable is set at startup time by placing it in your startup script in `package.json`: | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM w/ nit, once the CI is green. |
Fixes #236