build!: update library to use Node 12 #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: cloudprofiler
bcoe
approved these changes
May 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 69.15% 68.87% -0.28%
==========================================
Files 7 7
Lines 1248 1253 +5
Branches 58 58
==========================================
Hits 863 863
- Misses 384 389 +5
Partials 1 1
Continue to review full report at Codecov.
|
nolanmar511
approved these changes
May 18, 2022
alexander-fenster
approved these changes
May 18, 2022
alexander-fenster
approved these changes
May 18, 2022
sofisl
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
sofisl
added
the
automerge
1 task
sofisl
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 30, 2022
🤖 I have created a release *beep* *boop* --- ## [5.0.0](v4.2.0...v5.0.0) (2022-06-20) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#835) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#843](#843)) ([1af6b0f](1af6b0f)) * **deps:** update dependency @google-cloud/logging-min to v10 ([#838](#838)) ([1120298](1120298)) ### Build System * update library to use Node 12 ([#835](#835)) ([07221ef](07221ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
nolanmar511
reviewed
Jul 6, 2022
| @@ -20,5 +23,7 @@ | |||
| "posttest": "npm run check" | |||
| }, | |||
| "devDependencies": {}, | |||
| "dependencies": {} | |||
| "dependencies": { | |||
| "@google-cloud/profiler": "^4.2.0" | |||
There was a problem hiding this comment.
I think this change means the system test will always run with @google-cloud/profiler 4.2.0?
If so, that would mean the system test won't work anymore
grayside
pushed a commit
to GoogleCloudPlatform/nodejs-docs-samples
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release *beep* *boop* --- ## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#835) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f)) * **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298)) ### Build System * update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
to GoogleCloudPlatform/nodejs-docs-samples
that referenced
this pull request
Nov 12, 2022
🤖 I have created a release *beep* *boop* --- ## [5.0.0](googleapis/cloud-profiler-nodejs@v4.2.0...v5.0.0) (2022-06-20) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#835) ### Bug Fixes * **deps:** update dependency @google-cloud/common to v4 ([#843](googleapis/cloud-profiler-nodejs#843)) ([1af6b0f](googleapis/cloud-profiler-nodejs@1af6b0f)) * **deps:** update dependency @google-cloud/logging-min to v10 ([#838](googleapis/cloud-profiler-nodejs#838)) ([1120298](googleapis/cloud-profiler-nodejs@1120298)) ### Build System * update library to use Node 12 ([#835](googleapis/cloud-profiler-nodejs#835)) ([07221ef](googleapis/cloud-profiler-nodejs@07221ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate library to Node 12