Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

allowExpressions configuration option not documented #1008

Closed
govindrai opened this issue Sep 20, 2021 · 1 comment · Fixed by #1172
Closed

allowExpressions configuration option not documented #1008

govindrai opened this issue Sep 20, 2021 · 1 comment · Fixed by #1172
Assignees
@mctavish
Labels
api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API.

Comments

@govindrai
Copy link

After you follow the directions to setup the debugger,
you get into the UI and then realize you can't use snapshots or logpoints because:

image

None of the examples show the allowExpressions configuration option and the documentation doesn't call it out/explain the option anywhere (at least I was not able to find this on the github repo nor the official google cloud debugger docs).

Please document it, otherwise you have to redeploy the app again.
@product-auto-label product-auto-label bot added the api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. label Sep 20, 2021
@mctavish mctavish self-assigned this Sep 21, 2021
@mctavish mctavish added priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API. labels Sep 21, 2021
@mctavish
Copy link
Contributor

Valid feedback. The documentation should be updated to both include the allowExpressions option in the examples. It should probably also be included in the samples in this repo.

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Mar 20, 2022
@mctavish mctavish mentioned this issue Sep 25, 2023
Merged
4 tasks
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 2, 2023
@mctavish
docs: add documentation for common config parameters (#1172)
1f772d2 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [x] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/cloud-debug-nodejs/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [x] Ensure the tests and linter pass
- [x] Code coverage does not decrease (if any source code was changed)
- [x] Appropriate docs were updated (if necessary)

Fixes #1008 🦕
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mctavish mctavish

Labels
api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add documentation for common config parameters mctavish/cloud-debug-nodejs
3 participants
@mctavish @govindrai @yoshi-automation