Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AIP-123): resource type name matches message #1452

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat(AIP-123): resource type name matches message #1452

merged 1 commit into from
Dec 20, 2024
+176 −0

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Dec 17, 2024 •
edited
Loading

Enforce AIP-123 guidance that the resource type name should match the containing proto message name.

Addresses internal bug: http://b/384544409

@noahdietz noahdietz requested a review from a team as a code owner December 17, 2024 20:51
@noahdietz noahdietz requested a review from slevenick December 17, 2024 20:52
@noahdietz noahdietz merged commit 8f3e2ac into googleapis:main Dec 20, 2024
5 checks passed
@noahdietz noahdietz deleted the aip-123-type-message branch December 20, 2024 22:01
@release-please release-please bot mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slevenick slevenick slevenick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @slevenick