Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update module github.com/jhump/protoreflect to v1.15.4 #1296

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Dec 8, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/jhump/protoreflect v1.15.3 -> v1.15.4 age adoption passing confidence

Release Notes

jhump/protoreflect (github.com/jhump/protoreflect)

v1.15.4

Compare Source

This is a bugfix release to address bugs in the desc/protoprint package and a compatibility issue with the most recent version of github.com/bufbuild/protocompile.

"github.com/jhump/protoreflect/desc/protoparse"

Changes/fixes:

  • As of v1.15.0, this package uses the github.com/bufbuild/protocompile package under the hood as the parser. But that package is still using major version zero, since it's API has not completely stabilized. A recent release (v0.7.0) included backwards-incompatible changes that caused this repo to no longer compile. This release addresses the compile errors: this repo now uses that latest release of protocompile and correctly compiles against it.
"github.com/jhump/protoreflect/desc/protoprint"

Changes/fixes:

  • When a string literal included a double-quote character ("), it would get printed incorrectly leading to either an incorrect string literal in some cases or an invalid and uncompilable source file in others. This has been fixed.
  • When sorting elements in the file, if the file used proto3 syntax and had an enum with negative numeric values, the result would include the negative values first, before the zero value. This is not allowed in proto3 syntax, which requires that the zero value be the first value, so the result would be an invalid and uncompilable source file. This has been fixed.
  • When a source file is parsed into a FileDescriptorProto but never linked, the descriptor may be missing the type field of a FieldDescriptorProto (since it is not known whether a named type refers to a message, group, or enum), and it may have options left in the uninterpreted_options field of the various options messages, which has a peculiar representation for aggregate values. When printing a descriptor that had these characteristics, they were not correctly handled, so the output of the printer would be an invalid and uncompilable source file. Both of these cases have been fixed.

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@forking-renovate forking-renovate bot added the automerge Summon MOG for automerging label Dec 8, 2023
@renovate-bot renovate-bot requested a review from a team as a code owner December 8, 2023 01:11
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Dec 8, 2023
@renovate-bot renovate-bot force-pushed the renovate/github.aaakk.us.kg-jhump-protoreflect-1.x branch 2 times, most recently from 56bec16 to 0210342 Compare January 2, 2024 21:21
@renovate-bot renovate-bot force-pushed the renovate/github.aaakk.us.kg-jhump-protoreflect-1.x branch from 34ebdee to 68349aa Compare January 2, 2024 21:31
@andrei-scripniciuc andrei-scripniciuc enabled auto-merge (squash) January 2, 2024 21:40
@andrei-scripniciuc andrei-scripniciuc merged commit 344d977 into googleapis:main Jan 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants