feat: add response metadata to V16 GAPIC Clients #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiboknacky
reviewed
Apr 25, 2024
src/Google/Ads/GoogleAds/Lib/V16/UnaryGoogleAdsResponseMetadataCallable.php
Outdated
Show resolved
Hide resolved
fiboknacky
reviewed
Apr 25, 2024
src/Google/Ads/GoogleAds/Lib/V16/UnaryGoogleAdsResponseMetadataCallable.php
Show resolved
Hide resolved
bshaffer
changed the title
fiboknacky
requested changes
Apr 25, 2024
src/Google/Ads/GoogleAds/Lib/V16/UnaryGoogleAdsResponseMetadataCallable.php
Show resolved
Hide resolved
fiboknacky
approved these changes
Apr 25, 2024
|
Thanks! |
fiboknacky
added a commit
that referenced
this pull request
Apr 30, 2024
…1022) * feat: add response metadata to V16 GAPIC Clients (#1013) * feat!: refactor response metadata for V16 * this change should ensure that the response metadata is null when the request fails * fixes from PR review * add missing import * Patch the v16_1 source. (#1020) Somehow, the source wasn't updated to the latest version even after re-generating it last time. * Updated CHANGELOG.md for releasing a patch for the Google Ads API v16_1 source code (#1021) * Release for v23.0.1. --------- Co-authored-by: Brent Shaffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC for refactoring response metadata in V16 to be a method
getResponseMetadataon the Gapic Client.