Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ExceptionUtilities class and refactor some common functionality. #478

Merged
merged 5 commits into from
Jan 27, 2023

Conversation

AnashOommen
Copy link
Member

No description provided.

@AnashOommen AnashOommen requested a review from a team as a code owner January 3, 2023 16:40
@AnashOommen AnashOommen self-assigned this Jan 3, 2023
@AnashOommen AnashOommen requested review from PierrickVoulet and removed request for Raibaz January 3, 2023 17:12
PierrickVoulet
PierrickVoulet previously approved these changes Jan 3, 2023
Raibaz
Raibaz previously approved these changes Jan 26, 2023
Copy link
Contributor

@Raibaz Raibaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise LGTM.

Google.Ads.Gax/src/Util/ExceptionUtilities.cs Outdated Show resolved Hide resolved
Copy link

@sundquist sundquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnashOommen AnashOommen merged commit e509e30 into main Jan 27, 2023
@AnashOommen AnashOommen deleted the add-exception-utilities branch January 27, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants