Inline layout validation and pointer cast code to optimize out panic #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… panics in `validate_cast_and_convert_metadata`. If `try_cast_into` and `validate_cast_and_convert_metadata` are not inlined, then the compiler will include a panic in `validate_cast_and_convert_metadata`. If these functions are inlined, then the panic can be optimized out.
|
The test failures are unrelated and known to be an issue. I'll open a PR quick to fix them, and then we can rebase this. |
|
PR backporting our earlier fix to v0.8.x: #1998 |
jswrenn
approved these changes
Oct 31, 2024
joshlf
pushed a commit
that referenced
this pull request
Nov 4, 2024
… panics in (#1997) `validate_cast_and_convert_metadata`. If `try_cast_into` and `validate_cast_and_convert_metadata` are not inlined, then the compiler will include a panic in `validate_cast_and_convert_metadata`. If these functions are inlined, then the panic can be optimized out.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 4, 2024
… panics in (#1997) (#2013) `validate_cast_and_convert_metadata`. If `try_cast_into` and `validate_cast_and_convert_metadata` are not inlined, then the compiler will include a panic in `validate_cast_and_convert_metadata`. If these functions are inlined, then the panic can be optimized out. Co-authored-by: Carl Lundin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
try_cast_intoandvalidate_cast_and_convert_metadataare not inlined, then the compiler will include a panic invalidate_cast_and_convert_metadata.If these functions are inlined, then the panic can be optimized out.
Additional context can be found at #1661 (comment)