Use tomllib on Python 3.11+ #1152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallback to tomli for compatibility with older Python
|
Would you like to do similar for |
| @@ -52,11 +52,14 @@ def _GetExcludePatternsFromPyprojectToml(filename): | |||
| """Get a list of file patterns to ignore from pyproject.toml.""" | |||
| ignore_patterns = [] | |||
| try: | |||
| import tomli as tomllib | |||
There was a problem hiding this comment.
Not a fan of nested try/catches in favor of https://peps.python.org/pep-0484/#version-and-platform-checking style approach.
I'm also wondering if moving the import to ./yapf/yapflib/__init__.py is a good idea idea vs. conditional login in every file.
Lastly, this package is now part of the package requirements, so managing an ImportError may no longer be applicable.
import sys
if sys.version_info >= (3, 11):
import tomllib
else:
import tomli as tomllib
Spitfire1900
suggested changes
Sep 28, 2023
|
Looks like requested changes are in #1158 now. Closing in favor of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to tomli for compatibility with older Python