copy globals()

[Spitfire1900]

Fixes #1118. Use a copy of globals() rather than a direct reference. This did not appear to impact the time of tests.

[Spitfire1900]

Requesting review from @bwendling and @char101 .
Requesting testing from @eunwoosh.

[char101]

If you copy the globals(), isn't the list() part not required anymore?

[char101]

Probably the module is imported twice at the same time, the first import finished the loop a bit faster, and then it adds ISTERMINAL, etc. to the global scope, which broke the second import which is still looping. We could also fix this by moving the loop to the bottom of the file.

[Spitfire1900]

So we're using 3.7, so I've elected to use copy() and dictionary comprehension here, while dropping the list() wrapper.

[Spitfire1900]

Probably the module is imported twice at the same time, the first import finished the loop a bit faster, and then it adds ISTERMINAL, etc. to the global scope, which broke the second import which is still looping. We could also fix this by moving the loop to the bottom of the file.

This makes logical sense... a bit. I may be out of the loop here but I would think that if a module is imported twice the first import blocks until initialization completes.

[eunwoosh]

Requesting review from @bwendling and @char101 . Requesting testing from @eunwoosh.

I tested and the error isn't raised anymore. Thanks for fixing it.