Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason parameter to waitFor. #305

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

VandorpeDavid
Copy link
Contributor

This parameter allows customizing the error message if the waitFor fails.

This parameter allows customizing the error message if the waitFor fails.
Copy link

@iinozemtsev iinozemtsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@natebosch
Copy link
Member

My changes should not have caused firefox tests to start failing. I don't know whether these have been flaky, or if something external changed to break these.

@natebosch
Copy link
Member

oh, it looks like these have just been failing and we have been ignoring it...

@natebosch natebosch merged commit 4998763 into google:master Nov 2, 2024
7 of 10 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Nov 4, 2024
…arkdown, package_config, pool, pub_semver, shelf, source_maps, source_span, stack_trace, stream_channel, string_scanner, sync_http, term_glyph, test_descriptor, test_process, test_reflective_loader, tools, vector_math, watcher, web, web_socket_channel, webdriver, webkit_inspection_protocol, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/9ad6888..4b62792):
  4b627929  2024-11-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/core#716)

csslib (https://github.com/dart-lang/csslib/compare/7f5f84e..3cfa58c):
  3cfa58c  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-archive/csslib#209)

ecosystem (https://github.com/dart-lang/ecosystem/compare/5099841..52e4ceb):
  52e4ceb  2024-11-01  dependabot[bot]  Bump the github-actions group with 5 updates (dart-lang/ecosystem#317)

glob (https://github.com/dart-lang/glob/compare/3e414a2..b6319d6):
  b6319d6  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/glob#99)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/a9e71fa..c8aabe3):
  c8aabe3  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/http_multi_server#74)

lints (https://github.com/dart-lang/lints/compare/19d99bc..f72e5ce):
  f72e5ce  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 (dart-lang/lints#215)

markdown (https://github.com/dart-lang/markdown/compare/a4b1d2c..776689c):
  776689c  2024-11-01  Sam Rawlins  Add one more note to the 7.2.3 changelog before publishing (dart-lang/markdown#628)
  4a293d8  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/markdown#629)

package_config (https://github.com/dart-lang/package_config/compare/bafff8e..2583a4e):
  2583a4e  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/package_config#160)

pool (https://github.com/dart-lang/pool/compare/7bfc71b..0bac9b2):
  0bac9b2  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/pool#92)

pub_semver (https://github.com/dart-lang/pub_semver/compare/72317ea..ab3eab5):
  ab3eab5  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/pub_semver#109)

shelf (https://github.com/dart-lang/shelf/compare/f560053..1a141c7):
  1a141c7  2024-11-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/shelf#454)

source_maps (https://github.com/dart-lang/source_maps/compare/17695e8..b20b970):
  b20b970  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/source_maps#97)

source_span (https://github.com/dart-lang/source_span/compare/e518512..f147469):
  f147469  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/source_span#119)

stack_trace (https://github.com/dart-lang/stack_trace/compare/582891c..63e79f5):
  63e79f5  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/stack_trace#165)

stream_channel (https://github.com/dart-lang/stream_channel/compare/f440716..9bfc2a8):
  9bfc2a8  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/stream_channel#112)

string_scanner (https://github.com/dart-lang/string_scanner/compare/4de83f0..255d671):
  255d671  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/string_scanner#84)

sync_http (https://github.com/dart-lang/sync_http/compare/44b5913..82362bc):
  82362bc  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 (google/sync_http.dart#52)

term_glyph (https://github.com/dart-lang/term_glyph/compare/d7d8d7c..31abb04):
  31abb04  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/term_glyph#58)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/aa99e99..7119567):
  7119567  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/test_descriptor#73)

test_process (https://github.com/dart-lang/test_process/compare/c4986dd..7c76f47):
  7c76f47  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/test_process#64)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/598af2f..30a552d):
  30a552d  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/test_reflective_loader#66)

tools (https://github.com/dart-lang/tools/compare/5f4f945..b028012):
  b028012c  2024-11-04  Kevin Moore  Fix analysis across packages (dart-lang/tools#1187)
  f5d3a196  2024-10-31  Sam Rawlins  Merge pull request `#684` from dart-lang/srawlins-patch-1
  0c199dfa  2024-10-22  Sam Rawlins  Fix doc comment references with backticks

vector_math (https://github.com/google/vector_math.dart/compare/3937447..ec5080d):
  ec5080d  2024-11-01  dependabot[bot]  Bump the github-actions group with 2 updates (google/vector_math.dart#334)

watcher (https://github.com/dart-lang/watcher/compare/3b85077..7a15a90):
  7a15a90  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/watcher#172)

web (https://github.com/dart-lang/web/compare/d3a61aa..8d24376):
  8d24376  2024-11-01  dependabot[bot]  Bump the github-actions group with 2 updates (dart-lang/web#319)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/1f15eca..abe77ea):
  abe77ea  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/web_socket_channel#386)

webdriver (https://github.com/google/webdriver.dart/compare/accfed5..4998763):
  4998763  2024-11-02  David Vandorpe  Add reason parameter to waitFor. (google/webdriver.dart#305)
  ffcd45e  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 (google/webdriver.dart#306)
  19d0d7a  2024-11-01  Devon Carew  Update analysis_options.yaml (google/webdriver.dart#307)

webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/b459c42..a834c3b):
  a834c3b  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (google/webkit_inspection_protocol.dart#131)

yaml (https://github.com/dart-lang/yaml/compare/6cc2745..402655e):
  402655e  2024-11-01  dependabot[bot]  Bump actions/checkout from 4.2.0 to 4.2.2 in the github-actions group (dart-lang/yaml#172)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/35f4248..3d1421b):
  3d1421b  2024-11-01  dependabot[bot]  Bump the github-actions group across 1 directory with 2 updates (dart-lang/yaml_edit#98)

Change-Id: I2f35fd3023e6c587b8a52bcc0d1f8376786fe300
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393383
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants