-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMD: Time-based UUID Generator & Parser #85
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this. Before it is checked in it will need documentation (package comment) and a copyright statement.
Also, it appears to assume a V1 UUID. It should be checking to see what type of UUID it is and then display the information from the UUID based on the type of UUID. A V4 UUID, for example, will only have random data and no timestamp.
Greetings! Sorry, but can I just remove the random function for now? I mean, I did this implementation because I can't cross-compile OSSP-uuid for armel (my phone), honestly I don't use the Random function. I did it for testing, but I only use time-based uuid. Can I implement it in the future? |
No description provided.