Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Dart 3, update lints, enable analysis language modes #50

Merged
merged 7 commits into from
Jun 15, 2023

Conversation

parlough
Copy link
Contributor

@parlough parlough commented Jun 15, 2023

I'm trying to remove usages of the deprecated strong-mode options. This PR does so and enables the newer analysis language modes as replacements. It also updates to Dart 3 and package:dart_flutter_team_lints at the same time.

Removal issue reference: dart-lang/sdk#50679

\cc @kevmoo

@parlough parlough marked this pull request as ready for review June 15, 2023 19:18
CHANGELOG.md Outdated Show resolved Hide resolved
@parlough parlough changed the title Require Dart 2.17, update lints, enable analysis language modes Require Dart 3, update lints, enable analysis language modes Jun 15, 2023
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@kevmoo
Copy link
Collaborator

kevmoo commented Jun 15, 2023

Trying migrating to dart_flutter_team_lints instead – then see if CI runs 😄

@kevmoo
Copy link
Collaborator

kevmoo commented Jun 15, 2023

NICE!

@parlough
Copy link
Contributor Author

Looks like the workflows might be disabled because of inactivity. Perhaps let's kick start them with #51?

@kevmoo
Copy link
Collaborator

kevmoo commented Jun 15, 2023

rebase on latest?

@parlough
Copy link
Contributor Author

parlough commented Jun 15, 2023

Thanks for your help @kevmoo! #53 should fix the build error.

@kevmoo kevmoo merged commit 449904a into google:master Jun 15, 2023
@parlough parlough deleted the misc/update-analysis-options branch June 15, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants