optional uri queryparams #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,6 +50,7 @@ class UriParser extends UriPattern { | |||
|
|
|||
| final UriTemplate template; | |||
| final bool _fragmentPrefixMatching; | |||
| final bool _queryParamsAreOptional; | |||
There was a problem hiding this comment.
not the best name. Thoughts?
There was a problem hiding this comment.
it's private and sounds good in an if statement, so it's fine by me
|
Fixes #14 |
|
Thanks for the patch! |
| UriParser(UriTemplate this.template, {bool fragmentPrefixMatching: true}) | ||
| : _fragmentPrefixMatching = firstNonNull(fragmentPrefixMatching, true) { | ||
| UriParser(UriTemplate this.template, {bool fragmentPrefixMatching: true, | ||
| bool queryParamsAreOptional: false}) |
There was a problem hiding this comment.
style nit: when wrapping named parameters I like to just put every one on a new line
|
Looks good. Can you squash the commits? Thanks! |
Andersmholmgren
force-pushed
the
feature/fix_uri_queryparams
branch
from
a0b49a0 to
ceeb21b
Compare
|
OK PR review changes applied and commit squashed. Please merge and publish to pub |
justinfagnani
added a commit
that referenced
this pull request
Jul 31, 2015
optional uri queryparams
|
Thanks! |
|
Great work! Don't forget to close out #14 @sethladd or @justinfagnani |
|
thanks @justinfagnani Please publish to pub |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justin, this is an initial stab at supporting optional query params for matching.
Once we get to the point where you are happy with it I'll tidy up and squash the commits