Decouple the version of GWT from the version of the GWT Maven Plugin, and bump GWT. #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
… and bump GWT. The plugin that we use has stopped being upgraded. We should really migrate off it, but in the meantime, we can at least upgrade GWT. It turns out that we can't upgrade to the _newest_ version of GWT because its version of the Eclipse compiler detects a mismatch between the `guava-android` and `guava-jre` _internal implementation code_, since the Truth tests mix the two. I guess that Dependabot will try to upgrade us, anyway. We can [try](#1348) to tell it to stop. RELNOTES=n/a PiperOrigin-RevId: 711507563
copybara-service
bot
force-pushed
the
test_711502767
branch
from
431bbf0 to
eb7f431
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decouple the version of GWT from the version of the GWT Maven Plugin, and bump GWT.
The plugin that we use has stopped being upgraded. We should really migrate off it, but in the meantime, we can at least upgrade GWT.
It turns out that we can't upgrade to the newest version of GWT because its version of the Eclipse compiler detects a mismatch between the
guava-androidandguava-jreinternal implementation code, since the Truth tests mix the two. I guess that Dependabot will try to upgrade us, anyway. We can try to tell it to stop.RELNOTES=n/a