Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GTFS-Fares v2] Add fare_leg_join_rules.txt #439

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

tzujenchanmbd
Copy link
Collaborator

@tzujenchanmbd tzujenchanmbd commented Apr 2, 2024

This PR is based on Google's fare_leg_join_rules.txt proposal. At the workgroup meeting on February 27th, the following consensus was reached:

  • Predicates for from_network_id and to_network_id will be added first, followed by the addition of other predicates such as from_stop_id and to_stop_id.
  • from_network_id and to_network_id are required fields, and initially will be restricted to the same network_id. We will consider relaxing this for different network_id later.

Changes in this PR

  • Add Effective Fare Leg in term definition
  • Add fare_leg_join_rules.txt
  • Modify network_id, from_area_id, to_area_id, from_timeframe_group_id, to_timeframe_group_id in fare_leg_rules.txt for effective fare leg

For previous discussions please see the working group meeting note and issue#346

Please go through the changes and feel free to share your thoughts/questions here.

@tzujenchanmbd tzujenchanmbd added GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Extension: GTFS-Fares Issues and Pull Requests that focus on GTFS-Fares Extension Status: Discussion Issues and Pull Requests that are currently being discussed and reviewed by the community. Change: Addition New function proposed to the specification. Support: Needs Review Needs support to review proposal. labels Apr 2, 2024
@isabelle-dr isabelle-dr linked an issue Apr 25, 2024 that may be closed by this pull request
@tzujenchanmbd
Copy link
Collaborator Author

tzujenchanmbd commented Nov 6, 2024

In the October meeting, the working group reached a consensus to add from_stop_id and to_stop_id. (Meeting notes) Commits 4c978de & 32f3224 included these two fields. (Meeting notes)

During the meeting working group also recognized the potential for further expansion of this file in the future, including:

  • Allowing joins across different networks
  • Mechanism for negation

@tzujenchanmbd tzujenchanmbd changed the title [GTFS-Fares v2] Add fare_leg_join_rules.txt (first iteration) [GTFS-Fares v2] Add fare_leg_join_rules.txt Nov 7, 2024
@tzujenchanmbd tzujenchanmbd removed the GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule label Nov 19, 2024
@tzujenchanmbd
Copy link
Collaborator Author

Hello,

We have at least one producer: Ito. They have shared their dataset extract in this file, which is part of a private feed.
We have at least one consumer: Google. Please see the screenshot below.

As per the GTFS amendment process, the requirements to open a vote are met.
We are opening a vote for adding fare_leg_join_rules.txt.

Voting ends on 2024-12-03 at 23:59:59 UTC.

Screenshot 2024-11-18 at 11 09 04 AM

@tzujenchanmbd tzujenchanmbd added Status: Voting Pull Requests where the advocate has called for a vote as described in the changes.md and removed Status: Discussion Issues and Pull Requests that are currently being discussed and reviewed by the community. labels Nov 19, 2024
@halbertram
Copy link

+1 from Ito

@westontrillium
Copy link
Contributor

+1 from Trillium

@jfabi
Copy link
Contributor

jfabi commented Dec 2, 2024

+1 from the @mbta

@tzujenchanmbd
Copy link
Collaborator Author

The vote passed on 2024-12-03 at 23:59:59 UTC.

3 votes in favour and no votes against.

Votes came from:
Ito (@halbertram)
Trillium (@westontrillium)
MBTA (@jfabi)

Thank you to everyone who participated!

@tzujenchanmbd tzujenchanmbd removed Status: Voting Pull Requests where the advocate has called for a vote as described in the changes.md Support: Needs Review Needs support to review proposal. labels Dec 5, 2024
@tzujenchanmbd tzujenchanmbd merged commit 7be58b0 into google:master Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change: Addition New function proposed to the specification. Extension: GTFS-Fares Issues and Pull Requests that focus on GTFS-Fares Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GTFS-Fares v2: One route behaviour
4 participants