Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining feature flags #267

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Remove remaining feature flags #267

merged 1 commit into from
Oct 2, 2019

Conversation

vorot93
Copy link
Contributor

@vorot93 vorot93 commented Oct 1, 2019 •
edited
Loading

A very hacky solution yet tests pass. Fixes #242.

@tikue
Copy link
Collaborator

tikue commented Oct 1, 2019

Left a few minor comments; looks great though! Thank you:)

@vorot93
Copy link
Contributor Author

vorot93 commented Oct 2, 2019

I have addressed the comments. Please take a look again.

tikue
tikue approved these changes Oct 2, 2019
View reviewed changes
rpc/src/server/filter.rs Show resolved Hide resolved
@tikue tikue merged commit e910058 into master Oct 2, 2019
@vorot93 vorot93 deleted the stable branch October 2, 2019 20:12
@tikue tikue mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tikue tikue tikue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target stable Rust
2 participants
@vorot93 @tikue