Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Expose package metadata from wheels in .par files #49

Merged
merged 4 commits into from
Nov 9, 2017

Conversation

duggelz
Copy link
Contributor

@duggelz duggelz commented Nov 4, 2017

Almost fixes #38

@duggelz duggelz force-pushed the dgreiman/issue38 branch 2 times, most recently from a6b5d34 to a4740c2 Compare November 4, 2017 03:53
@duggelz duggelz changed the title [WIP] Expose package metadata from wheels in .par files Expose package metadata from wheels in .par files Nov 4, 2017
@duggelz duggelz requested a review from mattmoor November 7, 2017 00:50
Doug Greiman added 2 commits November 8, 2017 16:49
`pkg_resources` creates a default WorkingSet as soon as it is
imported, so even though we add hooks for it to find the .dist-info
metadata inside .par files, it is too late.  So we manually update the
default WorkingSet, trying not to disturb existing entries.
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I mostly followed this. thank you :)

@duggelz
Copy link
Contributor Author

duggelz commented Nov 9, 2017

I think I know how to fix the wheel problem, but I'll do it as a separate change.

@duggelz duggelz merged commit 051d7f6 into master Nov 9, 2017
@duggelz duggelz deleted the dgreiman/issue38 branch November 9, 2017 06:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PAR picks up system-installed version instead of bundled version
2 participants