Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Availability of the immintrin.h should not implicitly disable support… #105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gruuk
Copy link

@gruuk gruuk commented Oct 7, 2020

… of all pre-Haswell CPUs. User needs to explicitly specify AVX2 requirement via SNAPPY_REQUIRE_AVX2 if it was their intention.

@google-cla
Copy link

google-cla bot commented Oct 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 7, 2020
@gruuk
Copy link
Author

gruuk commented Oct 7, 2020

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 7, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@gruuk
Copy link
Author

gruuk commented Oct 7, 2020

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Oct 7, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

… of all pre-Haswell CPUs. User needs to explicitly specify AVX2 requirement via SNAPPY_REQUIRE_AVX2 if it was their intention.
@gruuk gruuk force-pushed the explicitly_ask_for_avx2 branch from 36574c8 to 43ef82b Compare October 7, 2020 12:23
@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant