Exclude (not set) city and country from reports. #9943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 4e851a3 are ready:
|
|
Size Change: -4 B (0%) Total Size: 1.98 MB
ℹ️ View Unchanged
|
techanvil
requested changes
Jan 2, 2025
| @@ -79,15 +79,15 @@ const ANALYTICS_4_DIMENSION_OPTIONS = { | |||
| 'United States', | |||
| 'United Kingdom', | |||
| 'India', | |||
| '(not set)', | |||
| 'Portugal', | |||
There was a problem hiding this comment.
Please revert this change. We still want to mock the (not set) value being returned in the mock report data, as we don't filter it out in all of our reports.
Suggested change
| 'Portugal', | |
| '(not set)', |
| 'France', | ||
| 'Ukraine', | ||
| 'Italy', | ||
| 'Mexico', | ||
| ], | ||
| city: [ | ||
| 'Dublin', | ||
| '(not set)', | ||
| 'Mumbai', |
There was a problem hiding this comment.
As above:
Suggested change
| 'Mumbai', | |
| '(not set)', |
Comment on lines
55
to
62
| dimensionFilters: { | ||
| city: { | ||
| filterType: 'stringFilter', | ||
| matchType: 'EXACT', | ||
| value: '(not set)', | ||
| notExpression: true, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
This is not the correct approach and doesn't follow the IB.
In fact, this filtering approach is what was specified in the original IB, and it won't meet the AC for the reasons discussed in #7884 (comment).
Please review the IB and amend the implementation appropriately.
Comment on lines
55
to
62
| dimensionFilters: { | ||
| country: { | ||
| filterType: 'stringFilter', | ||
| matchType: 'EXACT', | ||
| value: '(not set)', | ||
| notExpression: true, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
The same comment applies here as the one for the TopCitiesWidget.
ankitrox
force-pushed
the
enhancement/7884-remove-not-set-key-metrics
branch
from
aa8171d to
a4cdb3a
Compare
techanvil
requested changes
Jan 3, 2025
Comment on lines
89
to
98
| const filteredCities = ( cityRows ) => | ||
| cityRows.some( | ||
| ( { dimensionValues } ) => | ||
| dimensionValues[ 0 ].value === '(not set)' | ||
| ) | ||
| ? cityRows.filter( | ||
| ( { dimensionValues } ) => | ||
| dimensionValues[ 0 ].value !== '(not set)' | ||
| ) | ||
| : cityRows.slice( 0, 3 ); |
There was a problem hiding this comment.
As per this comment, #7884 (comment), we should create a reusable function for this logic, please can you lift this out as a common helper and reuse it in TopCountriesWidget.
As well as making it generic, we can simplify it a bit, e.g.:
function reportRowsWithSetValues( rows, maxRows = 3 ) {
const rowsWithSetValues = rows.filter(
( { dimensionValues } ) =>
dimensionValues[ 0 ].value !== '(not set)'
);
return rowsWithSetValues.slice( 0, maxRows );
}
|
Thank you @techanvil . I have created a separated utility function so that we can use it in both places. Also added tests for the function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist