Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix btn label flicker (Follow Up). #7568

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

zutigrm
Copy link
Collaborator

@zutigrm zutigrm commented Sep 11, 2023

Summary

Addresses issue:

Relevant technical choices

This PR fixes the issue @wpdarren caught in this comment

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

Size Change: +157 B (0%)

Total Size: 1.4 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 22.1 kB +2 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js 32.3 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 23.2 kB -2 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 64.8 kB -3 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 80.8 kB +142 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 106 kB +4 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 66.2 kB +9 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js 88 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-optimize-********************.js 18.9 kB +1 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.8 kB +1 B (0%)
./dist/assets/js/googlesitekit-splash-********************.js 65.3 kB +1 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 39.9 kB +2 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 26.2 kB -2 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62.8 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 51.4 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.3 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.55 kB
./dist/assets/js/30-********************.js 2.8 kB
./dist/assets/js/31-********************.js 2.28 kB
./dist/assets/js/32-********************.js 3.72 kB
./dist/assets/js/33-********************.js 929 B
./dist/assets/js/34-********************.js 888 B
./dist/assets/js/35-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 53.8 kB
./dist/assets/js/googlesitekit-api-********************.js 9.56 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.62 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 9.99 kB
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 17.7 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.1 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-modules-********************.js 21 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 20.4 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 59.2 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B
./dist/assets/js/googlesitekit-settings-********************.js 47.3 kB
./dist/assets/js/googlesitekit-vendor-********************.js 317 kB
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Build files for cb41a4a have been deleted.

Copy link
Contributor

@kuasha420 kuasha420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zutigrm. Code LGTM and works as expected. Nice one 🎉

@kuasha420 kuasha420 merged commit 00ace53 into develop Sep 12, 2023
@kuasha420 kuasha420 deleted the enhancement/7467-follow-up branch September 12, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants