-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Analytics setup form UI for split into four sub-variants (depending GA4 support and available properties) #3331
Prepare Analytics setup form UI for split into four sub-variants (depending GA4 support and available properties) #3331
Conversation
Size Change: +240 B (0%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @danielgent. It mostly looks good to me. Just added a few comments to fix formatting and storybook issues.
ba3afef
to
3fb2b51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @danielgent. A few more comments:
07ade09
to
94be501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @danielgent.
Summary
Addresses issue #3247
Relevant technical choices
Checklist