Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Analytics setup form UI for split into four sub-variants (depending GA4 support and available properties) #3331

Merged

Conversation

danielgent
Copy link
Contributor

@danielgent danielgent commented May 11, 2021

Summary

Addresses issue #3247

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label May 11, 2021
@github-actions
Copy link

github-actions bot commented May 11, 2021

Size Change: +240 B (0%)

Total Size: 1.29 MB

Filename Size Change
./dist/assets/js/googlesitekit-adminbar.********************.js 67.4 kB -1 B (0%)
./dist/assets/js/googlesitekit-api.********************.js 9.39 kB -3 B (0%)
./dist/assets/js/googlesitekit-dashboard-details.********************.js 79 kB -2 B (0%)
./dist/assets/js/googlesitekit-dashboard-splash.********************.js 49.4 kB +26 B (0%)
./dist/assets/js/googlesitekit-dashboard.********************.js 79.6 kB -2 B (0%)
./dist/assets/js/googlesitekit-data.********************.js 1.65 kB -1 B (0%)
./dist/assets/js/googlesitekit-datastore-forms.********************.js 9.06 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-location.********************.js 2.03 kB +2 B (0%)
./dist/assets/js/googlesitekit-datastore-site.********************.js 12.5 kB -2 B (0%)
./dist/assets/js/googlesitekit-datastore-ui.********************.js 9.02 kB +1 B (0%)
./dist/assets/js/googlesitekit-datastore-user.********************.js 16 kB +1 B (0%)
./dist/assets/js/googlesitekit-module.********************.js 79.7 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-adsense.********************.js 57.1 kB +3 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4.********************.js 11.6 kB +1 B (0%)
./dist/assets/js/googlesitekit-modules-analytics.********************.js 63 kB +241 B (0%)
./dist/assets/js/googlesitekit-modules-optimize.********************.js 17.6 kB -7 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights.********************.js 24.3 kB +3 B (0%)
./dist/assets/js/googlesitekit-modules-search-console.********************.js 27.9 kB -5 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager.********************.js 31.6 kB +4 B (0%)
./dist/assets/js/googlesitekit-modules.********************.js 17.2 kB +3 B (0%)
./dist/assets/js/googlesitekit-settings.********************.js 87 kB -6 B (0%)
./dist/assets/js/googlesitekit-user-input.********************.js 84.4 kB -4 B (0%)
./dist/assets/js/googlesitekit-vendor.********************.js 271 kB -8 B (0%)
./dist/assets/js/googlesitekit-widgets.********************.js 11.5 kB -1 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard.********************.js 67.2 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/assets/css/admin.css 36.1 kB 0 B
./dist/assets/css/adminbar.css 7.33 kB 0 B
./dist/assets/css/wpdashboard.css 4.43 kB 0 B
./dist/assets/js/analytics-advanced-tracking.js 769 B 0 B
./dist/assets/js/googlesitekit-activation.********************.js 35.5 kB 0 B
./dist/assets/js/googlesitekit-base.********************.js 1.57 kB 0 B
./dist/assets/js/googlesitekit-i18n.js 3.92 kB 0 B
./dist/assets/js/googlesitekit-modules-idea-hub.********************.js 9.63 kB 0 B
./dist/assets/js/runtime.********************.js 763 B 0 B

compressed-size-action

Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danielgent. It mostly looks good to me. Just added a few comments to fix formatting and storybook issues.

@danielgent danielgent force-pushed the enhancement/3247-Prepare-split-Analytics-form-UI branch from ba3afef to 3fb2b51 Compare May 11, 2021 16:57
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @danielgent. A few more comments:

stories/module-analytics-setup.stories.js Outdated Show resolved Hide resolved
@danielgent danielgent force-pushed the enhancement/3247-Prepare-split-Analytics-form-UI branch from 07ade09 to 94be501 Compare May 12, 2021 14:08
Copy link
Collaborator

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @danielgent.

@eugene-manuilov eugene-manuilov merged commit db4d644 into develop May 12, 2021
@eugene-manuilov eugene-manuilov deleted the enhancement/3247-Prepare-split-Analytics-form-UI branch May 12, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants