Enhancement/3157 save idea info #3320
Merged
+304
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
requested changes
May 12, 2021
tests/phpunit/includes/TestCase.php
Outdated
| protected function assertPostMetaHasValue( $post_id, $meta_key, $meta_value ) { | ||
| $meta = $this->queryPostMeta( $post_id, $meta_key ); | ||
| $this->assertNotNull( $meta ); | ||
| $this->assertEquals( $meta_value, $meta['meta_value'], "Failted to assert that post $post_id has \"$meta_key\" meta with \"$meta_value\" value." ); |
There was a problem hiding this comment.
Suggested change
| $this->assertEquals( $meta_value, $meta['meta_value'], "Failted to assert that post $post_id has \"$meta_key\" meta with \"$meta_value\" value." ); | |
| $this->assertEquals( $meta_value, $meta['meta_value'], "Failed to assert that post $post_id has \"$meta_key\" meta with \"$meta_value\" value." ); |
There was a problem hiding this comment.
Seems like a misspelling here, but then it did pass. What's causing this to emit "failted"? I couldn't find it in our code, but is it worth noting why that… typo appears? 🤷🏻♂️
There was a problem hiding this comment.
@tofumatt the last parameter is just a friendly message that will be displayed if the first two parameters don't equal.
Co-authored-by: Matthew Riley MacPherson <[email protected]>
tofumatt
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #3157
Relevant technical choices
Checklist