Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/3168 matching ga4 properties #3311

Merged
merged 7 commits into from
May 6, 2021

Conversation

eugene-manuilov
Copy link
Collaborator

@eugene-manuilov eugene-manuilov commented May 6, 2021

Summary

Addresses issue #3168

Relevant technical choices

  • Refactored URL-related utility functions. Moved getFullURL, getURLPath, and normalizeURL functions into a new urls.js file.
  • Removed duplicate function getLocale from the util/index.js file.

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@google-cla google-cla bot added the cla: yes label May 6, 2021
@eugene-manuilov eugene-manuilov marked this pull request as ready for review May 6, 2021 18:20
@github-actions
Copy link

github-actions bot commented May 6, 2021

Size Change: +1.49 kB (0%)

Total Size: 1.28 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation.********************.js 35.5 kB +399 B (+1%)
./dist/assets/js/googlesitekit-adminbar.********************.js 67.4 kB -66 B (0%)
./dist/assets/js/googlesitekit-api.********************.js 9.37 kB +63 B (+1%)
./dist/assets/js/googlesitekit-dashboard-details.********************.js 78.9 kB -85 B (0%)
./dist/assets/js/googlesitekit-dashboard-splash.********************.js 49.4 kB -38 B (0%)
./dist/assets/js/googlesitekit-dashboard.********************.js 79.6 kB -74 B (0%)
./dist/assets/js/googlesitekit-data.********************.js 1.65 kB -2 B (0%)
./dist/assets/js/googlesitekit-datastore-forms.********************.js 9.04 kB +84 B (+1%)
./dist/assets/js/googlesitekit-datastore-location.********************.js 2.03 kB -2 B (0%)
./dist/assets/js/googlesitekit-datastore-site.********************.js 12.5 kB +15 B (0%)
./dist/assets/js/googlesitekit-datastore-ui.********************.js 9.01 kB +77 B (+1%)
./dist/assets/js/googlesitekit-datastore-user.********************.js 16 kB +36 B (0%)
./dist/assets/js/googlesitekit-module.********************.js 79.7 kB -74 B (0%)
./dist/assets/js/googlesitekit-modules-adsense.********************.js 57.3 kB +154 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4.********************.js 11.6 kB +525 B (+5%) 🔍
./dist/assets/js/googlesitekit-modules-analytics.********************.js 62.8 kB +30 B (0%)
./dist/assets/js/googlesitekit-modules-idea-hub.********************.js 8.83 kB +76 B (+1%)
./dist/assets/js/googlesitekit-modules-optimize.********************.js 17.5 kB +53 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights.********************.js 24.3 kB -7 B (0%)
./dist/assets/js/googlesitekit-modules-search-console.********************.js 27.8 kB +60 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager.********************.js 31.6 kB +153 B (0%)
./dist/assets/js/googlesitekit-modules.********************.js 17.2 kB +32 B (0%)
./dist/assets/js/googlesitekit-settings.********************.js 87 kB -73 B (0%)
./dist/assets/js/googlesitekit-user-input.********************.js 84.4 kB -79 B (0%)
./dist/assets/js/googlesitekit-vendor.********************.js 271 kB +205 B (0%)
./dist/assets/js/googlesitekit-widgets.********************.js 11.5 kB +88 B (+1%)
./dist/assets/js/googlesitekit-wp-dashboard.********************.js 67.2 kB -65 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/assets/css/admin.css 36 kB 0 B
./dist/assets/css/adminbar.css 7.33 kB 0 B
./dist/assets/css/wpdashboard.css 4.43 kB 0 B
./dist/assets/js/analytics-advanced-tracking.js 769 B 0 B
./dist/assets/js/googlesitekit-base.********************.js 1.57 kB 0 B
./dist/assets/js/googlesitekit-i18n.js 3.92 kB 0 B
./dist/assets/js/runtime.********************.js 763 B 0 B

compressed-size-action

import getFullURL from '../util/getFullURL';
import { getFullURL } from '../util';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but why this change?

I think in the past we separated the utils files to prevent chances of circular imports… but aside from that I don't have much of a preference 🙂

@tofumatt tofumatt merged commit 8c341d3 into develop May 6, 2021
@tofumatt tofumatt deleted the enhancement/3168-matching-ga4-properties branch May 6, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants