Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress dependencies update #1762

Merged
merged 9 commits into from
Jul 13, 2020

Conversation

eugene-manuilov
Copy link
Collaborator

@eugene-manuilov eugene-manuilov commented Jul 11, 2020

Summary

Addresses issue #1356

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@eugene-manuilov eugene-manuilov marked this pull request as ready for review July 12, 2020 19:38
@felixarntz
Copy link
Member

@eugene-manuilov I've downgraded React as part of this one back to 16.12.0 due to this error when opening a Site Kit module's settings that only surfaces on 16.13+:

Warning: Cannot update a component (`%s`) while rendering a different component (`%s`). To locate the bad setState() call inside `%s`, follow the stack trace as described in https://fb.me/setstate-in-render%s PermissionsModal AdBlockerWarning AdBlockerWarning 
        in AdBlockerWarning
        in Unknown
        in InnerComponent (created by WithFilters(ModuleSettingsWarning))
        in WithFilters(ModuleSettingsWarning)
        in div
        in SetupModule
        in SettingsModule
        in div
        in div
        in div
        in div
        in Layout
        in div
        in SettingsModules
        in div
        in div
        in div
        in SettingsApp
        in RestoreSnapshots
        in ErrorHandler
        in Root

We can investigate this problem via a separate issue, for now let's make sure we can wrap up this initial bulk dependency updates issue.

I've also done another minor WP dependency update since those new versions were literally published as I was reviewing the PR.

@felixarntz felixarntz merged commit 277f492 into develop Jul 13, 2020
@felixarntz felixarntz deleted the enhancement/1356-wordpress-deps-update branch July 13, 2020 22:05
@aaemnnosttv aaemnnosttv mentioned this pull request Jul 14, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants