Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enahncement/1356 lint packages upgrade #1740

Merged
merged 14 commits into from
Jul 9, 2020
Merged

Enahncement/1356 lint packages upgrade #1740

merged 14 commits into from
Jul 9, 2020
+4,338 −1,458

Conversation

eugene-manuilov
Copy link
Collaborator

Summary

Addresses issue #1356

Relevant technical choices

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Sorry, something went wrong.

@eugene-manuilov eugene-manuilov mentioned this pull request Jul 3, 2020
Closed
@eugene-manuilov eugene-manuilov marked this pull request as ready for review July 3, 2020 20:07
felixarntz
felixarntz requested changes Jul 7, 2020
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, however let's fix or granularly ignore lint violations rather than entirely skipping the respective rules.

@felixarntz felixarntz merged commit 3cd7c31 into develop Jul 9, 2020
@felixarntz felixarntz deleted the enahncement/1356-lint-packages-upgrade branch July 9, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eugene-manuilov @felixarntz @googlebot