Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gulp and rework gulp tasks. #1737

Merged
merged 10 commits into from
Jul 8, 2020
Merged

Upgrade gulp and rework gulp tasks. #1737

merged 10 commits into from
Jul 8, 2020

Conversation

eugene-manuilov
Copy link
Collaborator

Summary

Addresses issue #1356

Relevant technical choices

Upgrade gulp and its dependencies to the latest versions and reworked gulp tasks. Tasks that we don't use anymore have been removed. Other tasks have been refactored to follow gulp 4 approach and moved to the gulpfile.js folder (which is recommended by gulp itself).

Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 4.7 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

@eugene-manuilov eugene-manuilov marked this pull request as ready for review July 3, 2020 12:33
@eugene-manuilov eugene-manuilov mentioned this pull request Jul 3, 2020
Closed
felixarntz
felixarntz requested changes Jul 7, 2020
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just a few comments.

gulpfile.js/copy.js Show resolved Hide resolved
.eslintignore Outdated Show resolved Hide resolved
gulpfile.babel.js Show resolved Hide resolved
@felixarntz felixarntz merged commit fd01c7d into develop Jul 8, 2020
@felixarntz felixarntz deleted the enhancement/1356-gulp-upgrade branch July 8, 2020 22:19
@aaemnnosttv aaemnnosttv mentioned this pull request Jan 28, 2021
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugene-manuilov @felixarntz @googlebot