Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case where enhanced measurement settings are changed on Analytics after setting them in Site Kit. #7477

Open
techanvil opened this issue Aug 21, 2023 · 0 comments
Labels
Module: Analytics Google Analytics module related issues P2 Low priority Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Aug 21, 2023

Feature Description

If enhanced measurement settings are changed on Analytics after setting them in Site Kit, the implication is that any configured ECCT widget tile that depends on enhanced measurement may be affected.

We need to consider how to handle this scenario:

  1. We could track the configured state in Site Kit and then show a banner to update it in Site Kit if there are changes on the Analytics side.
  2. If the user sets up an ECCT widget tile that depends on a given enhanced measurement setting being enabled and it's subsequently disabled on the Analytics side, then we show a banner to prompt the user to re-enable it.

The first approach would require a bit of extra server-side state and some polling of the EM settings, whereas the second approach seems like something we might want to build into the ECCT feature anyway. Therefore it might simply be better to handle this in the ECCT epic too (see #7476).


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues P2 Low priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants