Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning notice when enabling enhanced measurement with no events enabled. #7475

Closed
techanvil opened this issue Aug 21, 2023 · 1 comment
Labels
Module: Analytics Google Analytics module related issues Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Aug 21, 2023

Feature Description

If there are no enhanced measurement events enabled for the currently selected data stream, enabling enhanced measurement for the stream will have no tangible effect. This is a rare edge case as it requires the user to have explicitly taken the steps to disable all of the events.

With this being such an unlikely edge case, it doesn't seem worthwhile trying to engineer an overly complex solution that involves Site Kit enabling some or all of the events. Rather, we should simply show a warning notice when enabling enhanced measurement with no events enabled.

Therefore, we should add a warning notice to the "Enable enhanced measurements" toggle and banner when there are no events enabled for the selected web data stream. The notice should include a link to the selected web data stream's settings page on the Analytics site.

Toggle:

image

Banner:

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@aaemnnosttv
Copy link
Collaborator

Thanks @techanvil – after reviewing, we've decided to handle this as part of #7476 and #7477 rather than a separate issue with a focus on the specific settings that are important for us rather than treating "all" as a special case.

@aaemnnosttv aaemnnosttv closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants