Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spm proto headers to install #623

Merged
merged 2 commits into from
Feb 23, 2021
Merged

add spm proto headers to install #623

merged 2 commits into from
Feb 23, 2021

Conversation

erasaur
Copy link
Contributor

@erasaur erasaur commented Feb 10, 2021

first off, thanks for all your work on this project!

I came across a small issue trying to run through the example here -- currently, if I follow the instructions for installing from source, the protobuf headers aren't installed so the example fails (can't #include <sentencepiece.pb.h>). not sure if I'm just missing some steps but I figure I should submit the PR in case this is indeed an oversight.

to be precise, I'm using ubuntu and running these commands for installing (not using builtin proto):

% sudo apt-get install cmake build-essential pkg-config libgoogle-perftools-dev libprotobuf-dev protobuf-compiler
% git clone https://github.com/google/sentencepiece.git 
% cd sentencepiece
% mkdir build
% cd build
% cmake -DSPM_USE_BUILTIN_PROTOBUF=OFF ..
% make -j $(nproc)
% sudo make install
% sudo ldconfig -v

@google-cla
Copy link

google-cla bot commented Feb 10, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Feb 10, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@erasaur
Copy link
Contributor Author

erasaur commented Feb 10, 2021

@googlebot I signed it!

@taku910 taku910 merged commit d429804 into google:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants