Change made to find_elements_by_semantic_locator_test.ts for accessib…

…le name: removes the empty form element. PiperOrigin-RevId: 643122843
google · Jun 18, 2024 · f97b9d6 · f97b9d6
1 parent f3db82f
commit f97b9d6
Show file tree

Hide file tree

Showing 9 changed files with 544 additions and 383 deletions.
diff --git a/docs/DEVELOPING.md b/docs/DEVELOPING.md
@@ -1,5 +1,7 @@
 # Developing Semantic Locators
 
+<!-- go/semantic-locators-developing -->
+
 ## Get a local copy of the code
 
 ```bash

diff --git a/docs/faq.md b/docs/faq.md
@@ -1,5 +1,7 @@
 # FAQ
 
+<!-- go/semantic-locators-faq -->
+
 ## How can I handle internationalization/localization (i18n/L10n)?
 
 Semantic locators don't yet have built-in support for tests with strong

diff --git a/docs/features.md b/docs/features.md
@@ -1,5 +1,7 @@
 # Features
 
+<!-- go/semantic-locators-features -->
+
 ## Basic syntax
 
 The following locator identifies an element anywhere on the page with a role of

diff --git a/docs/tutorial.md b/docs/tutorial.md
@@ -1,5 +1,7 @@
 # Tutorial
 
+<!-- go/semantic-locators-tutorial -->
+
 This doc is a step-by-step guide to writing (or auto-generating) semantic
 locators.
 

diff --git a/javascript/src/lib/role_map.ts b/javascript/src/lib/role_map.ts
@@ -11,7 +11,7 @@
 import {ConditionType, RoleSelector} from './types';
 
 /** Role which has no native HTML equivalent. */
-export type AriaOnlyRole = typeof ARIA_ONLY_ROLES_ARRAY[number];
+export type AriaOnlyRole = (typeof ARIA_ONLY_ROLES_ARRAY)[number];
 
 /** Type guard for AriaOnlyRole */
 export function isAriaOnlyRole(role: string): role is AriaOnlyRole {
@@ -26,7 +26,7 @@ export function isImplicitRole(role: string): role is ImplicitRole {
   return ROLE_MAP.hasOwnProperty(role);
 }
 /** Union type of all non-abstract ARIA roles. */
-export type AriaRole = AriaOnlyRole|ImplicitRole;
+export type AriaRole = AriaOnlyRole | ImplicitRole;
 
 /** Type guard for AriaRole */
 export function isAriaRole(role: string): role is AriaRole {
@@ -35,7 +35,7 @@ export function isAriaRole(role: string): role is AriaRole {
 
 /** Map from role to a RoleSelector for finding that role. */
 export type RoleMap = {
-  readonly[role in ImplicitRole]: RoleSelector;
+  readonly [role in ImplicitRole]: RoleSelector;
 };
 
 // clang-format off
@@ -88,7 +88,7 @@ export const CHILDREN_PRESENTATIONAL = [
   'math',
   'menuitemcheckbox',
   'menuitemradio',
-  // 'option', // TODO(b/180594818) enforce for option
+  // 'option', // TODO(b/340325104) Investigate turning this back on.
   'progressbar',
   'radio',
   'scrollbar',
@@ -98,14 +98,15 @@ export const CHILDREN_PRESENTATIONAL = [
   'tab',
 ] as const;
 
-type ChildrenPresentational = typeof CHILDREN_PRESENTATIONAL[number];
+type ChildrenPresentational = (typeof CHILDREN_PRESENTATIONAL)[number];
 
 /**
  * Whether the given role has presentational children.
  * https://www.w3.org/TR/wai-aria-practices/#children_presentational
  */
-export function isChildrenPresentational(role: AriaRole):
-    role is ChildrenPresentational {
+export function isChildrenPresentational(
+  role: AriaRole,
+): role is ChildrenPresentational {
   return CHILDREN_PRESENTATIONAL.includes(role as ChildrenPresentational);
 }