Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value_lexicon: Fix build with abseil LTS 2023-08-02 #334

Merged
merged 1 commit into from
Nov 22, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/s2/value_lexicon.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,6 @@
#include "s2/base/integral_types.h"
#include "s2/util/gtl/dense_hash_set.h"

class S2Point;
namespace absl {
namespace hash_internal {
template <typename T>
struct Hash;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure this was added because something was failing, but it's obviously wrong and we shouldn't be depending on abseil internals. I guess we can play whack-a-bug.

} // namespace hash_internal
} // namespace absl

// ValueLexicon is a class that maps distinct values to sequentially numbered
// integer identifiers. It automatically eliminates duplicates and uses a
// compact representation. See also SequenceLexicon.
Expand Down