Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible warning in header #287

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix possible warning in header #287

merged 1 commit into from
Dec 16, 2022

Conversation

MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Dec 14, 2022

if no defined ABSL_MIN_LOG_LEVEL severity_ will be unused.

Because its header it's pretty inconvenient.

As an alternative solution will be make field under ifdef.
But in this case layout of class will be changed, so I don't know, is it valid for you, I decide to make more simple fix.

@smcallis
Copy link
Collaborator

Seems like a reasonable workaround.

@smcallis smcallis merged commit 10b2e37 into google:master Dec 16, 2022
@jmr
Copy link
Member

jmr commented Dec 17, 2022

What does "possible warning" mean? Is there some compiler/set of options you actually observed a warning with?

This will all be deleted soon anyway, since absl now supports logging.

@MBkkt
Copy link
Contributor Author

MBkkt commented Dec 17, 2022

What does "possible warning" mean? Is there some compiler/set of options you actually observed a warning with?

Yes, gcc 11.2 with some flags, warnings about unused variable. But I think it can be avoided if we interprete s2 headers like system headers.

This will all be deleted soon anyway, since absl now supports logging.

Good we don't really use it.

@MBkkt
Copy link
Contributor Author

MBkkt commented Dec 17, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants