Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RemoveLast #267

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Fix RemoveLast #267

merged 1 commit into from
Aug 24, 2022

Conversation

MBkkt
Copy link
Contributor

@MBkkt MBkkt commented Aug 11, 2022

No description provided.

@jmr
Copy link
Member

jmr commented Aug 24, 2022

I don't understand the problem; can you explain how it's broken?

@MBkkt
Copy link
Contributor Author

MBkkt commented Aug 24, 2022

unary minus operator applied to unsigned type, result still unsigned

I don't think it's desirable

@jmr
Copy link
Member

jmr commented Aug 24, 2022

It's not broken unless ptrdiff_t and size_t aren't the same size, but I agree it's clearer your way.

@jmr jmr merged commit be91ef2 into google:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants