-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake install does not substitute or install the pkgconfig file #349
Comments
This has come up every so often and in varying ways, but this comment and this comment might be the most relevant to you. It still seems to me that CMake is unsuitable for packaging RE2, unfortunately, but the latter comment will hopefully help you. If there's a solution nowadays to the problem noted in the former comment, please let me know to reconsider my position. :) |
Thanks. Well, I am a package maintainer (for Fedora). In Fedora at least, building and shipping static libraries is explicitly discouraged, so that's not an issue at all. I ran across this because our re2 maintainer switched from Makefile to CMake building and inadvertently, uh, broke the entire distribution, so I was cleaning that up. The given reason for switching to CMake was "I'm in the preliminary phase of adding apache ORC and apache arrow. Both build with cmake only, and both need cmake style pkg info in/usr/lib*/cmake/re2/*". Presumably in order to switch back to Makefile building, if that's preferred, we'd need some solution for building those two things. |
Oh, thanks for the reference to the |
With With A while back, I helped gRPC folks (and package maintainers) by contributing |
Thanks. I guess it would, but we'd need to patch them into the apache projects downstream and ideally get them merged upstream. Since the only thing we need to 'fix' when using CMake to install re2 seems to be the pkgconfig file, I guess we'll just stick with the CMake approach for now. It seems like fixing the pkgconfig made everything that builds against it happy again. |
I was thinking more in the sense of trying to package |
The cmake build appears to be missing features, such as pkg-config generation support which is needed for some packages to find re2, like qt5webengine. Upstream is not keen on fixing the CMake-based buildsystem [0] Instead of patching it on our side, and then have to carry the patch forever, we switch to the Makefile-based generic buildsystem. Note that previously some packages like grpc failed when the generic Makefile was used, because they would not find the cmake-equivalent of pkg-config, but this is now fixed [1]. [0] google/re2#349 [1] grpc/grpc@45e413d Signed-off-by: James Hilliard <[email protected]> [Peter: Reword commit message as suggested by Yann] Signed-off-by: Peter Korsgaard <[email protected]>
If you do a CMake build/install of re2 on *nix, nothing substitutes
@includedir@
and@libdir@
inre2.pc
, or installs the file. This only happens in aMakefile
-driven installation.The text was updated successfully, but these errors were encountered: