README: clarify plugins search path #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
May 9, 2023
README.md
Outdated
| @@ -176,7 +176,8 @@ protobuf { | |||
| // Locate the codegen plugins | |||
| plugins { | |||
| // Locate a plugin with name 'grpc'. This step is optional. | |||
| // If you don't locate it, protoc will try to use "protoc-gen-grpc" from | |||
| // If you leave it empty, it uses the current directory. | |||
| // If you don't specify any plugins, protoc will try to use "protoc-gen-grpc" from | |||
There was a problem hiding this comment.
"any plugins" isn't fully accurate, because you can define one plugin and not another. I think just saying "it" may be clearest, to align with the previous sentence.
ejona86
approved these changes
May 10, 2023
YifeiZhuang
added a commit
to YifeiZhuang/protobuf-gradle-plugin
that referenced
this pull request
Jul 13, 2023
YifeiZhuang
added a commit
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #700