Delete eclipse idea #619
Closed
Delete eclipse idea #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rougsig
force-pushed
the
delete-eclipse-idea
branch
from
cde3e34 to
3736bd0
Compare
|
It's ready, but I'd rather leave it for the 0.10.0 release. |
|
With #636 this may be even easier, as we can create the folders earlier because we don't have to wait for the configuration to complete. (I'm not saying to change this PR, but that once both the PRs are merged we could move the mkdir()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Our plugin uses a deprecated API to configure IDEs. Actually the logic of the IDEs is to take the source declared in the gradle source sets. They do it well, we don't need to add additional configuration to the IDEs on our plugin side.
Changes
Remove IDEs support logic. IDEs support still exists, from gradle side.
Test plan
Green pipelines. IDEs still know about source sets.
References
gradle/gradle#22233
https://github.com/JetBrains/intellij-community/blob/master/plugins/gradle/testSources/org/jetbrains/plugins/gradle/util/GradleContentRootContributorTest.java