Simplify Kotlin DSL setup #531
Merged
+89
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest 6.x version
Since Gradle sets the maximum heap to 64m now, the minimum heap can't be set to 128M.
|
I see what seem to be good cleanups in here, but I don't see anything particular to what |
This is the documentation of the plugin and what it provides: https://docs.gradle.org/current/userguide/kotlin_dsl.html#sec:kotlin-dsl_plugin Sadly, I don't think it is possible to omit the version number from Groovy DSL scripts :(. So I looked up the version which ships with Gradle 6.9. |
ejona86
reviewed
Nov 3, 2021
src/main/kotlin/com/google/protobuf/gradle/ProtobufConfiguratorExts.kt
Outdated
Show resolved
Hide resolved
Since Gradle sets the maximum heap to 64m now, the minimum heap can't be set to 128M.
|
@ejona86 Thank you for the review, I addressed your comments. Please take another look! |
ejona86
approved these changes
Nov 3, 2021
- CI is set to true in Github action runs anyway. - The memory settings shouldn't be necessary any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got quite a few warnings when trying to upgrade Gradle to 6.9.1 on the build for #530. I was wondering if using the
kotlin-dslplugin could work, so less manual configuration is necessary.It seems like the compatibility class
KtDslCompatibilityUtilswas only there for Kotlin DSL versions prior to Gradle 5.0, and the plugin only supports Gradle 5.6. So I wonder if the changes I did would work and maybe simplify things.