Avoid running protobuf extract if unrelated files change #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change specifies ProtobufExtract more precisely, as only *.proto files will be included in up-to-date checks. E.g if a .jar files changes that contains no proto files, task will be up-to-date.
|
@voidzcy Can you please review this PR? |
voidzcy
reviewed
Nov 24, 2020
src/main/groovy/com/google/protobuf/gradle/ProtobufExtract.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/com/google/protobuf/gradle/ProtobufExtract.groovy
Outdated
Show resolved
Hide resolved
Have a single file collection for dirs and non-dirs, and instead apply filtering only when computing task inputs.
gavra0
force-pushed
the
protobuf-extract
branch
from
ea8a1a3 to
391d819
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change specifies ProtobufExtract more precisely, as only
*.proto files will be included in up-to-date checks. E.g if a .jar
files changes that contains no proto files, task will be up-to-date.