Fix ProtobufExtract task for Gradle Configuration Cache #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskatos
force-pushed
the
eskatos/cc/extract
branch
from
a2d3ba8 to
dea2e91
Compare
by using an ArchiveActionFacade in the same vein as CopyActionFacade in order to remove usage of Project at execution time ArchiveActionFacade uses the internal FileOperations type from Gradle. FileOperations is internal but quite stable and this plugin is already making use of other internals. Moreover, a public alternative will be available in Gradle 6.6 Signed-off-by: Paul Merlin <[email protected]>
eskatos
force-pushed
the
eskatos/cc/extract
branch
from
dea2e91 to
3f22e89
Compare
voidzcy
approved these changes
Jun 12, 2020
| @@ -0,0 +1,50 @@ | |||
| package com.google.protobuf.gradle; | |||
There was a problem hiding this comment.
Please add a file header for this new file.
Signed-off-by: Paul Merlin <[email protected]>
ejona86
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using an
ArchiveActionFacadein the same vein asCopyActionFacadein order to remove usage of Project at execution time.ArchiveActionFacadeuses the internalFileOperationstype from Gradle.FileOperationsis internal but quite stable and this plugin is already making use of other internals. Moreover, a public alternative will be available in Gradle 6.6 asArchiveOperations.See https://docs.gradle.org/nightly/userguide/configuration_cache.html