-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ToolsLocator to work with Gradle 6.1 Instant Execution #381
Fix ToolsLocator to work with Gradle 6.1 Instant Execution #381
Conversation
Signed-off-by: Paul Merlin <[email protected]>
adding coverage with Gradle 6.1 Signed-off-by: Paul Merlin <[email protected]>
I am wondering why only this change is needed to enable Instant Execution. Isn't migrating to configuration avoidance APIs a prerequisite? |
Configuration avoidance is orthogonal to instant execution. This change is required because heavyweight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this enhancement.
Hi, any chance we can get a plugin release with this fix? |
Looks like this is the only change since previous release. We might make a release after having more significant changes. |
It's been a bit more than a month and no other change got merged. Any chance you could consider releasing this improvement in a patch release? We and other teams are blocked on this. |
A new release would unblock one of our workstreams, so it'd be appreciated! |
Sure, I will do a release recently. |
0.8.12 is released and is available on maven central and Gradle plugin portal. |
This PR fixes
ToolsLocator
to comply with Gradle's Instant Execution constraints.See https://gradle.github.io/instant-execution/ for more information about what Instant Execution is.
The PR also enables test coverage for Gradle 6.1 and adds more coverage for using Instant Execution on a Java project.
The Android support isn't fixed for Instant Execution by this PR. I'll consider working on it afterwards. Having support for Java projects would already be awesome.