Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ToolsLocator to work with Gradle 6.1 Instant Execution #381

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

eskatos
Copy link
Contributor

@eskatos eskatos commented Jan 17, 2020

This PR fixes ToolsLocator to comply with Gradle's Instant Execution constraints.

See https://gradle.github.io/instant-execution/ for more information about what Instant Execution is.

The PR also enables test coverage for Gradle 6.1 and adds more coverage for using Instant Execution on a Java project.

The Android support isn't fixed for Instant Execution by this PR. I'll consider working on it afterwards. Having support for Java projects would already be awesome.

adding coverage with Gradle 6.1

Signed-off-by: Paul Merlin <[email protected]>
@voidzcy voidzcy self-assigned this Jan 17, 2020
@voidzcy voidzcy self-requested a review January 17, 2020 22:31
@voidzcy
Copy link
Collaborator

voidzcy commented Jan 21, 2020

I am wondering why only this change is needed to enable Instant Execution. Isn't migrating to configuration avoidance APIs a prerequisite?

@eskatos
Copy link
Contributor Author

eskatos commented Jan 22, 2020

Configuration avoidance is orthogonal to instant execution. This change is required because heavyweight Configuration instances can't be serialized by instant execution whereas FileCollection instances do work.

Copy link
Collaborator

@voidzcy voidzcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this enhancement.

@voidzcy voidzcy merged commit ac76dd5 into google:master Jan 23, 2020
@eskatos
Copy link
Contributor Author

eskatos commented Jan 29, 2020

Hi, any chance we can get a plugin release with this fix?

@voidzcy
Copy link
Collaborator

voidzcy commented Jan 29, 2020

Looks like this is the only change since previous release. We might make a release after having more significant changes.

@eskatos
Copy link
Contributor Author

eskatos commented Mar 5, 2020

It's been a bit more than a month and no other change got merged. Any chance you could consider releasing this improvement in a patch release? We and other teams are blocked on this.

@davidburstrom
Copy link

A new release would unblock one of our workstreams, so it'd be appreciated!

@voidzcy
Copy link
Collaborator

voidzcy commented Mar 5, 2020

Sure, I will do a release recently.

@voidzcy
Copy link
Collaborator

voidzcy commented Mar 5, 2020

0.8.12 is released and is available on maven central and Gradle plugin portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants