Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.10 #494

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Support GHC 9.10 #494

wants to merge 3 commits into from

Conversation

9999years
Copy link

Copy link

google-cla bot commented Oct 29, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@blackgnezdo
Copy link
Collaborator

blackgnezdo commented Oct 29, 2024

Thanks for the fixes! Would you mind extending our CI build matrix to include 9.10? I'd be happy if you repurpose the cabal build with ghc 9.6 / cabal test for this. We already have 9.10 covered by Stack and I don't see ghc-9.10 in stackage yet.

Copy link
Collaborator

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if everything passes and the file noted removed.

Comment on lines 12 to 13
- ghc: 9.6.3
cabal: 3.10.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ghc: 9.6.3
cabal: 3.10.2.0

We already have 9.6 covered by the stack matrix. Might as well not use it here. Could you remove ghc96.cabal files?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove.

@blackgnezdo
Copy link
Collaborator

Thanks @9999years !

Copy link
Collaborator

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again @9999years

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants