Make specialized parsers for Word32 and Word64.
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously they were implemented by a loop that didn't optimize well. This speeds up the benchmark from #277 (decoding repeated floats) by a factor of 2.6x. Specifically, the `float-packed/decode` and `float-unpacked/decode` benchmarks dropped from ~225us to ~85us.
judah
force-pushed
the
optimize-get-fixed
branch
from
19cd54c to
381bd6b
Compare
judah
changed the title
Word32 and Word64.
blackgnezdo
approved these changes
Dec 13, 2018
ylecornec
pushed a commit
to ylecornec/proto-lens
that referenced
this pull request
Feb 19, 2024
Previously they were implemented by a loop that didn't optimize well. This speeds up the benchmark from google#277 (decoding repeated floats) by a factor of 2.6x. Specifically, the `float-packed/decode` and `float-unpacked/decode` benchmarks dropped from ~225us to ~85us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously they were implemented by a loop that didn't optimize well.
This speeds up the benchmark from #277 (decoding repeated floats, reflected)
by a factor of 2.6x. Specifically, the
float-packed/decodeandfloat-unpacked/decodebenchmarks dropped from ~225us to ~85us.This change is