[NVIDIA] Use separate FP8 einsum instances in MoE #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found in the original version, the same fp8 einsum op is reused in the MoE by dispatch, FFN, combine gemm ops, meaning they will share the same fp8 meta params, which is wrong.
This PR fixed this issue by cloning the fp8 einsum to each of the gemm in the MoE.
cc. @zhangqiaorjc @abhinavgoel95 @hx89