Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display hovered box details immediately. #897

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

ghemawat
Copy link
Contributor

@ghemawat ghemawat commented Sep 25, 2024

Display the details (name + samples) of the currently hovered box above the flame graph. If no box is currently being hovered over, we display the total samples in the flame graph.

Fixes #836.

image

Display the details (name + samples) of the currently hovered box
above the flame graph. If no box is currently being hovered
over, we display the total samples in the flame graph.
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (0ed6a68) to head (4fd3b29).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #897      +/-   ##
==========================================
+ Coverage   66.86%   67.34%   +0.48%     
==========================================
  Files          44       44              
  Lines        9824     9825       +1     
==========================================
+ Hits         6569     6617      +48     
+ Misses       2794     2761      -33     
+ Partials      461      447      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aalexand
Copy link
Collaborator

I wonder if it would be useful if this new left details box would show the name of the pivot function when in pivot mode and not hovering any other node. This would give an easy way to copy to clipboard the name of a function of interest - pivot, move mouse to details, select, copy.

@ghemawat
Copy link
Contributor Author

I wonder if it would be useful if this new left details box would show the name of the pivot function when in pivot mode and not hovering any other node

In general, the pivot can be regexp so it can match many functions (useful for example to pivot on std::string to find all string usage). And the pivot is already fairly clear since we have an extra timing display just above the pivot(s). E.g., in the following we have pivoted on "swap":

image

@aalexand aalexand merged commit fa3061b into google:main Sep 25, 2024
31 checks passed
@aalexand
Copy link
Collaborator

I wonder if it would be useful if this new left details box would show the name of the pivot function when in pivot mode and not hovering any other node

In general, the pivot can be regexp so it can match many functions (useful for example to pivot on std::string to find all string usage). And the pivot is already fairly clear since we have an extra timing display just above the pivot(s). E.g., in the following we have pivoted on "swap":

I was mostly thinking about the general ability to easily copy the function name for a given flame graph node. It's a separate feature perhaps, doesn't have to be discussed now or even prioritized until people ask for it.

@hzeller
Copy link
Member

hzeller commented Sep 25, 2024

Thanks Sanjay!

@ghemawat ghemawat deleted the nohover branch September 26, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New flamegraph: 'hover shows details on the top' from old flame-graph missing
4 participants