Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use llvm-symbolizer's JSON output to provide function start lines #884

Closed
wants to merge 5 commits into from
Closed

Use llvm-symbolizer's JSON output to provide function start lines #884

wants to merge 5 commits into from

Conversation

insilications
Copy link
Contributor

When analyzing a perf.data profile converted automatically via perf_to_profile via pprof -raw perf.data, no function start lines (s=0) are present in any of the locations. With 813a5fb, this can be easily solved by using the same JSON frame data from llvm-symbolizer to provide StartLine for Function.start_line. This solves #823.

insilications and others added 2 commits August 17, 2024 08:39
When analyzing a perf.data profile converted automatically via perf_to_profile via `pprof -raw perf.data`, no function start lines (s=0) are present in any of the locations. With 813a5fb, this can be easily solved by using the same JSON frame data from `llvm-symbolizer` to provide `StartLine` for `Function.start_line`. This solves #823
Copy link
Collaborator

@aalexand aalexand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Would it be possible to add a test that exercises the new code?

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.01%. Comparing base (0ed6a68) to head (4f09060).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
+ Coverage   66.86%   67.01%   +0.14%     
==========================================
  Files          44       44              
  Lines        9824     9800      -24     
==========================================
- Hits         6569     6567       -2     
+ Misses       2794     2780      -14     
+ Partials      461      453       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When analyzing a perf.data profile converted automatically via perf_to_profile via `pprof -raw perf.data`, no function start lines (s=0) are present in any of the locations. With 813a5fb, this can be easily solved by using the same JSON frame data from `llvm-symbolizer` to provide `StartLine` for `Function.start_line`. This solves #823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants