Fix stacking order of profile details box. #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the profile details box (displayed when clicking button at top-right of web view), would partially overlap flame graph text. Tweak z-index values to fix this problem. Also, colocate all z-index CSS entries to make the stacking order of different things easier to compare.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
+ Coverage 66.86% 66.98% +0.11%
==========================================
Files 44 44
Lines 9824 9793 -31
==========================================
- Hits 6569 6560 -9
+ Misses 2794 2780 -14
+ Partials 461 453 -8 ☔ View full report in Codecov by Sentry. |
aalexand
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the profile details box (displayed when clicking button at top-right of web view), would partially overlap flame graph text. Tweak z-index values to fix this problem.
Also, colocate all z-index CSS entries to make the stacking order of different things easier to compare.